Docker demo - make "demo-ready" images from existing theia-based images #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
docker-demo
branch
18 times, most recently
from
0d51312 to
518568b
Compare
bhufmann
requested changes
Nov 29, 2024
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
Looks good to me. I was able build and run the demo apps. I found some typos which I ask you to fix.
docker/theia-app-demo/README.md
Outdated
| @@ -0,0 +1,65 @@ | |||
| # Resources for the "theia-app-demo" Example docker image | |||
|
|
|||
| This folder contains the resources, needed to create a "demo" Docker image, based on one of the Theia app images. The demo image includes the necessary extras to easity perform a quick demo or immediately play with the trace viewer: the Eclipse Trace Compass Trace Server and a selection of Tutorial traces. | |||
Contributor
Author
There was a problem hiding this comment.
Strange this was not caught by my spell checker!
docker/theia-app-demo/README.md
Outdated
|
|
||
| ### tate-demo (isolated docker network) | ||
|
|
||
| note: since the isolated docker network is used, you may start several containers from the tate-demo image and each one will have its own, indepandant trace server. |
These images are suitable for demos and quick experimentation. They build upon the existing images, adding the trace server and turorial traces on top. Signed-off-by: Marc Dumais <[email protected]>
The updated version has a button to open traces, which makes it possible to do so right in the trace view. It's still possible to open traces from the file navigator too. Signed-off-by: Marc Dumais <[email protected]>
Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
docker-demo
branch
from
518568b to
4b53d21
Compare
Contributor
Author
|
@bhufmann comments addressed |
bhufmann
approved these changes
Nov 29, 2024
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Looks good to me.
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to extend the existing images to make "demo" images, that include a trace server and the tutorial traces. These "demo" versions of the images can be fired-up and used immediately to do some trace viewing.
To get started quickly, look at the README under folder docker/theia-app-demo/